Don't raise KeyError when trying to navigate to nil next_page #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having trouble looping through paginated resources because the last page doesn't have a
next
link, and instead ofresource.pages.next
returningnil
, it raises aKeyError
.This PR attempts to fix it, but there are many questions raised from investigating:
KeyError
exception, which isn't explicitly related to a missing resource.nil
?[]
? an emptyResource
object?Or… am I iterating through pages the wrong way? Happy to complete this PR or add more documentation either way!
/cc @chingor13 @bvandenbos @sharshenov @reidab @dplummer